Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rate limit if root available and public claim_to consolidation #32

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix: Rate limit if root available and public claim_to consolidation #32

merged 2 commits into from
Oct 12, 2023

Conversation

desimmons
Copy link
Contributor

@desimmons desimmons commented Oct 11, 2023 •
edited
Loading

What does this PR do

Resolves this error in prod:

[TypeError: <dhali.rate_limiter.RateLimiter object at 0x3ee8980febc0> argument after ** must be a mapping, not NoneType](https://console.cloud.google.com/errors/CL-j4YPB0NiwCw?time=P1D&service=inference-gateway&project=dhali-prod)

How should this PR be tested?

Checklist before requesting a review

  • I have performed a self-review of my code

@desimmons desimmons force-pushed the fix-validation branch 2 times, most recently from 48b5f14 to 9e0d380 Compare October 11, 2023 19:46
@desimmons desimmons changed the title Fix: Only rate limit if root available Fix: Rate limit if root available and public claim_to consolidation Oct 12, 2023
@desimmons desimmons merged commit 7901606 into develop Oct 12, 2023
2 checks passed
@desimmons desimmons deleted the fix-validation branch October 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbie-daniels robbie-daniels robbie-daniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desimmons @robbie-daniels