Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatar and name to post #19

Merged
merged 11 commits into from
Aug 6, 2022

Conversation

swhemi
Copy link
Contributor

@swhemi swhemi commented Aug 3, 2022

I have worked accordingly to the contributing guide and added the user avatar and name to the post. I tried a few different ways that's why there are so many new posts. Sorry about that and thanks for letting me work on this issue.

@vercel
Copy link

vercel bot commented Aug 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seeit ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 5:07PM (UTC)

Copy link
Owner

@Dharmik48 Dharmik48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @swhemi! The code looks good!

I only have one suggestion, on smaller screens, the avatar isn't a proper circle and the font size is also very big.

So can you fix these two issues so we can merge the PR?

@swhemi
Copy link
Contributor Author

swhemi commented Aug 4, 2022

Hey, yeah sure, I will change that! Sorry, didn't check on that properly.

@swhemi
Copy link
Contributor Author

swhemi commented Aug 5, 2022

Hey @Dharmik48, I just changed the user avatar and name size. Is it okay this way or should it be smaller/bigger (if it's too small now)?

Copy link
Owner

@Dharmik48 Dharmik48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better but can you implement it with Tailwind CSS and not vanilla CSS?

@swhemi
Copy link
Contributor Author

swhemi commented Aug 5, 2022

Hey @Dharmik48, I just changed it into Tailwind CSS. First time working with Tailwind, hope it looks fine.

@mdazad1508
Copy link
Contributor

looks good @swhemi

Copy link
Owner

@Dharmik48 Dharmik48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work🎉

Looks way better! One last suggestion, even when there is so much available space, the username is getting wrapped to a new line.

image

Just fix that and it will be good to merge🚀

Copy link
Owner

@Dharmik48 Dharmik48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Great work @swhemi! This looks great!

Lets get it merged🎉 Thanks a lot for contributing🚀

@Dharmik48 Dharmik48 merged commit 5043363 into Dharmik48:main Aug 6, 2022
@swhemi
Copy link
Contributor Author

swhemi commented Aug 12, 2022

Thank you for letting me work on this issue! :)

@Dharmik48
Copy link
Owner

Dharmik48 commented Aug 13, 2022

Thank you for letting me work on this issue! :)

It was good to have you as a contributor😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants