-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add avatar and name to post #19
Conversation
# Conflicts: # src/App.jsx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @swhemi! The code looks good!
I only have one suggestion, on smaller screens, the avatar isn't a proper circle and the font size is also very big.
So can you fix these two issues so we can merge the PR?
Hey, yeah sure, I will change that! Sorry, didn't check on that properly. |
Hey @Dharmik48, I just changed the user avatar and name size. Is it okay this way or should it be smaller/bigger (if it's too small now)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better but can you implement it with Tailwind CSS and not vanilla CSS?
Hey @Dharmik48, I just changed it into Tailwind CSS. First time working with Tailwind, hope it looks fine. |
looks good @swhemi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…seeit into add-avatar-and-name-post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for letting me work on this issue! :) |
It was good to have you as a contributor😊 |
I have worked accordingly to the contributing guide and added the user avatar and name to the post. I tried a few different ways that's why there are so many new posts. Sorry about that and thanks for letting me work on this issue.