Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera opens twice when "Don't keep activities" option is ON #41

Closed
benji101 opened this issue Nov 14, 2019 · 3 comments
Closed

Camera opens twice when "Don't keep activities" option is ON #41

benji101 opened this issue Nov 14, 2019 · 3 comments
Assignees
Milestone

Comments

@benji101
Copy link

Doing some tests while having the developer option "Don't keep activities" turned on (that simulates what could happen when low on memory). After taking a picture, the camera is started again. Taking a second picture, it now behave like it should. Please note that I'm using the cameraOnly() option.

I think the problem is that ImagePickerActivity, in its onCreate method, is not considering the savedInstanceState Bundle (which is not null if the activity has been destroyed and is being re-created). What I'm not sure is why it's working the second time, and not going on a loop.

Anyone else has this problem or can reproduce it?

@Dhaval2404
Copy link
Owner

@benji101 I'm able to reproduce the issue. I will try to fix this issue asap.
Thank you so much for the feedback.

@benji101
Copy link
Author

@Dhaval2404 Thanks to you! I would have try to fix it myself, but I'm really busy at the moment, and I don't know Kotlin yet :(
Thanks for all the efforts you put in helping the community!

@Dhaval2404 Dhaval2404 self-assigned this Nov 14, 2019
@Dhaval2404 Dhaval2404 added this to the v1.6 milestone Dec 5, 2019
Dhaval2404 added a commit that referenced this issue Dec 9, 2019
Fixed Camera opens twice when "Don't keep activities" option is ON

#41
@Dhaval2404 Dhaval2404 mentioned this issue Jan 6, 2020
@kanczler
Copy link

Greetings! The camera still opens twice for me (only on my physical device, on emulators it's all right). Is there anything I could provide to help track down the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants