Release 2.0.0 #171

GuilhE · 2021-02-24T16:23:00Z

Changelog

Fork 2.0.0

CompressionProvider.kt logic refactor
Removed fun compress(maxSize: Int): Builder since it was comparing the size of the file and not the image (and the resize operation is enough);
Image maxResultSize (resize) algorithm refactor: fun maxResultSize(width: Int, height: Int, keepRatio: Boolean = false): Builde;
Replaced AsyncTask with coroutines

Fork 1.9.1

Removed all sstartActivityForResult from library since caller is responsible to provide an ActivityResultLauncher<Intent>
Removed https://github.com/florent37/InlineActivityResult dependency

Fork 1.9.0

Added Android Activity Result APIs

- Added two functions to be called with the new Result API - Gradle wrapper update - Gradle Dependencies update

costular · 2021-04-16T09:52:35Z

@Dhaval2404 could you check this one please? On May 5th Google will start removing apps from Play Store which use legacy storage

Drjacky · 2021-04-20T20:59:28Z

@GuilhE But in your version (release-2.0.0), the sample app compileSdkVersion and targetSdkVersion are not 30.
And if you set it to 30, even if you add

<queries>
        <intent>
            <action android:name="android.media.action.IMAGE_CAPTURE" />
        </intent>
</queries>

It still shows the error:

Failed to create Camera image file

GuilhE · 2021-04-21T07:47:59Z

@GuilhE But in your version (release-2.0.0), the sample app compileSdkVersion and targetSdkVersion are not 30.
And if you set it to 30, even if you add
<queries>
        <intent>
            <action android:name="android.media.action.IMAGE_CAPTURE" />
        </intent>
</queries>
It still shows the error:

Failed to create Camera image file

I'm using the following configuration in a project and it works with Pixel 3a running Android 11

object AndroidConstants {
    const val minSdkVersion = 24
    const val targetSdkVersion = 30
    const val compileSdkVersion = 30
    const val buildToolsVersion = "30.0.2"
}

But then I've found out that I've a merged manifest with:
<application android:requestLegacyExternalStorage="true">

So that's why it's working... 🤔 I'll dig into it as soon as possible.

GuilhE · 2021-04-21T07:54:07Z

@Drjacky ok quick update, I've removed that import and now there's no <application android:requestLegacyExternalStorage="true"> and it works... Do you declare any file provider?

    ...
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
    <queries>
        <intent>
            <action android:name="android.media.action.IMAGE_CAPTURE" />
        </intent>
    </queries>

    <application>
            ...
            <!--Providers-->
            <provider
                android:name=".utils.AppFileProvider"
                android:authorities="${applicationId}.files.provider"
                android:exported="false"
               android:grantUriPermissions="true">
                <meta-data
                    android:name="android.support.FILE_PROVIDER_PATHS"
                    android:resource="@xml/provider_paths" />
            </provider>
    </application>

class AppFileProvider : FileProvider()

<?xml version="1.0" encoding="utf-8"?>
<paths>
    <external-path
        name="external_files"
        path="." />
</paths>

Drjacky · 2021-04-21T08:13:16Z

@GuilhE
library's AndroidManifest.xml:

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.example.imagepicker">

    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />

    <application>

        <activity
            android:name="com.example.imagepicker.ImagePickerActivity"
            android:screenOrientation="unspecified"
            android:theme="@style/Theme.Transparent.ImagePicker" />

        <activity
            android:name="com.yalantis.ucrop.UCropActivity"
            android:screenOrientation="portrait"
            android:theme="@style/Theme.AppCompat.Light.NoActionBar" />

        <provider
            android:name="com.example.imagepicker.ImagePickerFileProvider"
            android:authorities="${applicationId}.imagepicker.provider"
            android:exported="false"
            android:grantUriPermissions="true">

            <meta-data
                android:name="android.support.FILE_PROVIDER_PATHS"
                android:resource="@xml/image_picker_provider_paths" />

        </provider>

    </application>

</manifest>

Sample app's AndroidManifest:

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.example.imagepicker.sample">

    <queries>
        <intent>
            <action android:name="android.media.action.IMAGE_CAPTURE" />
        </intent>
    </queries>

    <uses-permission android:name="android.permission.INTERNET" />

    <application
        android:allowBackup="true"
        android:fullBackupContent="false"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:roundIcon="@mipmap/ic_launcher_round"
        android:supportsRtl="true"
        android:theme="@style/AppTheme">
        <activity
            android:name="com.example.imagepicker.sample.MainActivity"
            android:label="@string/app_name"
            android:theme="@style/AppTheme.NoActionBar">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>
    </application>

</manifest>

Provider paths:

<?xml version="1.0" encoding="utf-8"?>
<paths>
    <external-path
        name="external_files"
        path="." />
    <files-path
        name="internal_files"
        path="." />
    <cache-path
        name="cache_files"
        path="." />
</paths>

Drjacky · 2021-04-21T08:41:42Z

@GuilhE Please use this sample app: https://github.com/GuilhE/ImagePicker/tree/release-2.0.0/sample
And set the targetSdk and compileSdk to 30, and you will see the error.

GuilhE · 2021-04-21T09:14:55Z

@Drjacky comment this line and it will work. I'll remove it from the sample.

Also, IDE complains about it:

 * @deprecated To improve user privacy, direct access to shared/external
     *             storage devices is deprecated. When an app targets
     *             {@link android.os.Build.VERSION_CODES#Q}, the path returned
     *             from this method is no longer directly accessible to apps.
     *             Apps can continue to access content stored on shared/external
     *             storage by migrating to alternatives such as
     *             {@link Context#getExternalFilesDir(String)},
     *             {@link MediaStore}, or {@link Intent#ACTION_OPEN_DOCUMENT}.
     */

If you import from Camera using the this method it works, again, because no Environment.getExternalStorageDirectory() is used.

GuilhE · 2021-04-21T09:43:56Z

@Drjacky new PR to avoid this problem.

Drjacky · 2021-04-21T14:59:44Z

@GuilhE On this PR please try to choose the image from Gallery - On Emulator API 30

GuilhE · 2021-04-21T17:33:54Z

@GuilhE On this PR please try to choose the image from Gallery - On Emulator API 30

Created a new AVD with API 30, took a picture with camera, and then used the app to import from Gallery, it worked 🤔

Drjacky · 2021-04-21T19:31:43Z

@GuilhE On this PR please try to choose the image from Gallery - On Emulator API 30

Created a new AVD with API 30, took a picture with camera, and then used the app to import from Gallery, it worked 🤔

You're right. with that scenario, it shows the taken picture.
What I did was, uploading a picture to the emulator in these folders:
sdcard -> DCIM -> HERE, sdcard -> DCIM -> Camera -> HERE, sdcard -> Download -> HERE, sdcard -> Pictures -> HERE, storage -> emulated -> 0 -> DCIM -> HERE, storage -> emulated -> 0 -> DCIM -> Camera -> HERE, storage -> emulated -> 0 -> Download -> HERE, storage -> emulated -> 0 -> Pictures -> HERE, storage -> 19F9-2A14 -> DCIM -> HERE, storage -> 19F9-2A14 -> DCIM -> Camera -> HERE, storage -> 19F9-2A14 -> Download -> HERE, storage -> 19F9-2A14 -> Pictures -> HERE.

And in the app, when I pressed Gallery, none of them had been listed!

Update: After a cold boot, it listed all of those pictures too ;)

Drjacky · 2021-04-21T19:58:06Z

@GuilhE Same PR, which works perfectly on Android API 30,

It doesn't work on Android API 29 , x86_64,

Camera: Failed to Create camera file image
Gallery: Failed to crop the image

Update: It works on Android API 28, x86

Update: It works on Android API 21, x86

Update: It doesn't work on Android API 29, x86 either

Drjacky · 2021-04-22T19:43:12Z

@GuilhE To fix the camera issue on API 29, I've changed the getCameraDirectory method to:

    private fun getCameraDirectory(context: Context): File {
        val dir =
            context.getExternalFilesDir(Environment.DIRECTORY_DCIM)// Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DCIM)
        return File(dir, "Camera")
    }

Now, the camera works on API 29 but, Gallery has the issue!
The root of the issue is here:

private val galleryLauncher =
        registerForActivityResult(ActivityResultContracts.StartActivityForResult()) {
            if (it.resultCode == Activity.RESULT_OK) {

it.resultCode is 0 while we're waiting for -1(Activity.RESULT_OK)

Update: The root of the Gallery issue on API 29 COULD BE here getImageFile:

java.io.IOException: Permission denied

Sometimes, I'm getting permission denied!

https://developer.android.com/about/versions/11/privacy/storage

Update: with .crop in fun pickGalleryImage(view: View) {m we get resultCode = 0 and if we remove .crop(), we get -1.
Then, the issue is here:
private val galleryLauncher =
...
imgGallery.setLocalImage(file)

The set image's resolution is zero!

GuilhE and others added 12 commits February 22, 2021 16:51

Added new Android Activity Result API

4adc400

- Added two functions to be called with the new Result API - Gradle wrapper update - Gradle Dependencies update

Update README.md

ce39be4

Update README.md

75b5538

Update README.md

be6fa63

Removed all startActivityForResult

c6d371e

sample update

44364c2

Update README.md

bce4e8d

Update README.md

5ea1d32

Update README.md

e64e2e3

Update README.md

d47d19a

CompressionProvider refactor

96d1abd

Update README.md

7b36747

GuilhE mentioned this pull request Mar 1, 2021

Crash on android 11 on returning result to onActivitity Result #173

Closed

Merge branch 'master' into release-2.0.0

c4307fd

GuilhE mentioned this pull request Apr 27, 2021

Release 2.0.1 #195

Closed

Drjacky mentioned this pull request Apr 30, 2021

Feat/Support Android API 28 API 29 API 30 Drjacky/ImagePicker#16

Merged

Dhaval2404 closed this May 28, 2021

GuilhE mentioned this pull request Sep 17, 2021

[Question] - Android versions Drjacky/ImagePicker#36

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.0.0 #171

Release 2.0.0 #171

GuilhE commented Feb 24, 2021

costular commented Apr 16, 2021 •

edited

Loading

Drjacky commented Apr 20, 2021

GuilhE commented Apr 21, 2021

GuilhE commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021

GuilhE commented Apr 21, 2021 •

edited

Loading

GuilhE commented Apr 21, 2021

Drjacky commented Apr 21, 2021

GuilhE commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 22, 2021 •

edited

Loading

Release 2.0.0 #171

Release 2.0.0 #171

Conversation

GuilhE commented Feb 24, 2021

Changelog

Fork 2.0.0

Fork 1.9.1

Fork 1.9.0

costular commented Apr 16, 2021 • edited Loading

Drjacky commented Apr 20, 2021

GuilhE commented Apr 21, 2021

GuilhE commented Apr 21, 2021 • edited Loading

Drjacky commented Apr 21, 2021 • edited Loading

Drjacky commented Apr 21, 2021

GuilhE commented Apr 21, 2021 • edited Loading

GuilhE commented Apr 21, 2021

Drjacky commented Apr 21, 2021

GuilhE commented Apr 21, 2021 • edited Loading

Drjacky commented Apr 21, 2021 • edited Loading

Drjacky commented Apr 21, 2021 • edited Loading

Drjacky commented Apr 22, 2021 • edited Loading

costular commented Apr 16, 2021 •

edited

Loading

GuilhE commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

GuilhE commented Apr 21, 2021 •

edited

Loading

GuilhE commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 21, 2021 •

edited

Loading

Drjacky commented Apr 22, 2021 •

edited

Loading