Update repository #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for event and manager factories
- Documentation corrected. - `trigger()` now accepts only one argument - the event instance. - Forward compatibility maintained, i.e. an implementation of the PSR event manager can implement the Dhii manager interface.
mecha
requested changes
Apr 1, 2018
FQNs refactored. Paths updated.
Fixes #2.
mecha
reviewed
Apr 2, 2018
| </include_path> | ||
| </component> | ||
| <component name="PhpProjectSharedConfiguration" php_language_level="5.3.0" /> | ||
| <component name="PhpUnit"> | ||
| <phpunit_settings> | ||
| <PhpUnitSettings load_method="CUSTOM_LOADER" configuration_file_path="F:/projects/dhii/psr-14/phpunit.xml" custom_loader_path="F:/projects/dhii/psr-14/vendor/autoload.php" phpunit_phar_path="" use_configuration_file="true" /> | ||
| <PhpUnitSettings load_method="CUSTOM_LOADER" custom_loader_path="F:/projects/dhii/event-interface/vendor/autoload.php" phpunit_phar_path="" /> |
There was a problem hiding this comment.
Why is it that this config entry never uses the $PROJECT_DIR$ variable for you?
There was a problem hiding this comment.
Mystery. Does it for you?
There was a problem hiding this comment.
Yes. In fact when I clone projects that have paths like this, after changing the beginning of the path from F:\projects to my D:\dev, PHPS automatically changes it to $PROJECT_DIR$.
There was a problem hiding this comment.
I would love my configs to do that. But they don't. Do you remember what it was like before the PHPS update?
There was a problem hiding this comment.
No. Would have to go look at some projects that I had created at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventInterfaceandEventManagerInterface.EventManagerInterfaceno longer extends PSR interface, and is strict, yet forward-compatible.Fixes #3.
Fixes #2.
Fixes #1.