Ported Teensy MIDI to serial MIDI #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhrBaksteen
requested changes
Jul 10, 2021
There was a problem hiding this comment.
Hi, Thanks a lot for your contribution!
I've tested it on my setup and it works as expected.
I have two small requests before I merge your PR:
- Can you please move the files into the top most SerialMidi folder and remove the nested one?
- Please update the comment that describes the example
| * This example can be used together with a Teensy 2.0 or later to use the OPL2 Audio Board as a MIDI device. To | ||
| * configure the Teensy as a MIDI device set USB Type to MIDI in the IDE using Tools > USB Type > MIDI. Once connected | ||
| * the board should appear in the device list as 'OPL2 AUdio Board MIDI'. You can now use test the board with, for | ||
| * example, MIDI-OX, your favorite music creation software or DosBox! |
There was a problem hiding this comment.
Can you please update the comment for the example? Please include the name / reference to the MIDI library that should be installed for the example. I tested it with https://github.com/FortySevenEffects/arduino_midi_library
Also feel free to credit yourself :)
There was a problem hiding this comment.
Updated comments, made the requested changes. They should be in teh latest commit.
Cheers, and thanks for the great library!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported your OPL2 teensy MIDI example to work on a Nano (probably also Uno). Should also work as a USB MIDI device with a pro-micro or Leonardo with a couple small changes (documented in the code comments)