Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1368: Fix incorrectly summed dose for DC groups when filtered #803

Merged
merged 2 commits into from
Sep 17, 2024
Merged

LIMS-1368: Fix incorrectly summed dose for DC groups when filtered #803

merged 2 commits into from
Sep 17, 2024

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1368

Summary:

When data collection groups are shown, the total dose is displayed by summing the dose for each data collection. But when you filter the view by "Auto Integrated", the extra joins to AutoProcIntegration etc mean extra rows are summed.

Changes:

  • Join to a subquery of simply dataCollectionGroupId and sum(totalAbsorbedDose) for each data collection group
  • Use the number from the subquery

To test:

  • Go to /samples/sid/5653602, look at the first data collection, the Total Dose should be 21.75MGy
  • Click the Auto Integrated filter, the total dose should not change
  • Check the same is true for the Data Collections and Full Collections filters
  • Go to /samples/sid/5653041 and check the Phasing filter
  • Go to /dc/visit/mx35120-12, look at the top data collection, check the Total Dose doesn't change with the Auto Integrated filter on/off
  • Go to /dc/visit/mx35120-12/dcg/12149523, check the dose for each data collection says 10.88MGy and doesn't change with the Auto Integrated filter on/off

@ndg63276 ndg63276 requested a review from NKatti2011 July 24, 2024 10:46
@NKatti2011
Copy link
Collaborator

Ready to Release

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.3 September 17, 2024 08:56
@ndg63276 ndg63276 merged commit 9a20f4c into pre-release/2024-R4.3 Sep 17, 2024
2 checks passed
ndg63276 added a commit that referenced this pull request Oct 1, 2024
@ndg63276
Merge pre-release/2024-R4.3 into master (#842)
087beda 
* LIMS-1368: Fix incorrectly summed dose for DC groups when filtered (#803)

* LIMS-1099: Limit what can be done with red proteins (#827)

* LIMS-14: Show a direct link to the autoprocessing log (#805)

* LIMS-1422: Reprocessing dialog edits the end value unpredictably (#819)

* LIMS-1424: Show visit for each container if set (#828)

* LIMS-1425: Show samples with no processing as grey (#820)
@ndg63276 ndg63276 deleted the fix/LIMS-1368/sum-dose-incorrect-when-filtered branch October 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NKatti2011 NKatti2011 Awaiting requested review from NKatti2011

Assignees
No one assigned
Labels
Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @NKatti2011