Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing Callback modules that subscribe to the RunEngine #257

Closed
DiamondJoseph opened this issue Jun 1, 2023 · 3 comments
Closed
Labels
worker Relates to worker code

Comments

@DiamondJoseph
Copy link
Contributor

Optionally: Make the current worker.events a callback in a default package of callbacks to make it optional

@callumforrester
Copy link
Contributor

One way to do this that is already supported

def my_plan() -> MsgGenerator:
    my_callback = MyCallback()
    my_other_callback = MyOtherCallback()

    @subs_decorator([my_callback, my_other_callback])
    def inner_plan() -> MsgGenerator:
        # actual plan logic goes here

    yield from inner_plan()

This could be sufficient...

@stan-dot
Copy link
Contributor

stan-dot commented Sep 9, 2024

@DiamondJoseph , what do you think?

@stan-dot stan-dot added the worker Relates to worker code label Sep 9, 2024
@DiamondJoseph
Copy link
Contributor Author

@DiamondJoseph , what do you think?

The linked issue has this left in Artemis/Hyperion/mx-blueksy's remit and was a year ago. I'm happy to close and re-open when we have more concrete requirements.

@callumforrester callumforrester closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worker Relates to worker code
Projects
None yet
Development

No branches or pull requests

3 participants