Replace interface singleton class with cached functions #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeshannon
commented
Jul 24, 2024
•
joeshannon
commented
- Remove commented out test code #570
joeshannon
force-pushed
the
568-singleton-to-cache
branch
2 times, most recently
from
ce694ff
to
323c5ce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 93.13% 93.05% -0.08%
==========================================
Files 42 42
Lines 1865 1844 -21
==========================================
- Hits 1737 1716 -21
Misses 128 128 ☔ View full report in Codecov by Sentry. |
joeshannon
force-pushed
the
568-singleton-to-cache
branch
3 times, most recently
from
38fc495
to
8417a7f
Compare
joeshannon
changed the title
joeshannon
force-pushed
the
568-singleton-to-cache
branch
from
8417a7f
to
ca9ec44
Compare
joeshannon
force-pushed
the
delete-commented-code
branch
from
a387311
to
65d9026
Compare
joeshannon
force-pushed
the
568-singleton-to-cache
branch
from
ca9ec44
to
37ba514
Compare
callumforrester
approved these changes
Jul 31, 2024
Replace with lru_cached functions. These will return the same value each time they are called. This simplifies the interface module. The tests and checks for working initialisation have been removed as they are no longer appropriate.
joeshannon
force-pushed
the
568-singleton-to-cache
branch
from
37ba514
to
37a6530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.