Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagingTemplate disconnect method should be idempotent #22

Open
abbiemery opened this issue Nov 24, 2023 · 1 comment
Open

MessagingTemplate disconnect method should be idempotent #22

abbiemery opened this issue Nov 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@abbiemery
Copy link
Contributor

The disconnect method for the messaging errors if called when it is already disconnected. Instead it should do nothing. To avoid this causing issues the stop method in service handler has had a if statement added to it to check if its connected before trying to disconnect it, but this should be able to be taken back out.

@stan-dot stan-dot added the bug Something isn't working label Mar 8, 2024
@stan-dot
Copy link
Contributor

stan-dot commented Mar 8, 2024

what are the steps to reproduce the issue? which disconnect method is this?
image

@stan-dot stan-dot transferred this issue from DiamondLightSource/blueapi Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants