Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct MirrorType declaration #556

Merged
merged 1 commit into from
May 21, 2024
Merged

Correct MirrorType declaration #556

merged 1 commit into from
May 21, 2024

Conversation

keithralphs
Copy link
Contributor

Fixes #537

Instructions to reviewer on how to test:

  1. Run Tests
  2. Alternatively pull change into scratch area of either p38 or i22 and restart BlueAPI, then Run count plan via BlueAPI on vfm or hfm device. No serialization error should be generated

This source of bugs in class declaration will be address as part of bluesky/ophyd-async#310

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly

@callumforrester
Copy link
Contributor

Test failures are due to incompatibility with the latest ophyd-async, @DominicOram working on it

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once ophyd-async issues are fixed, can rebase and the CI should pass to allow merge

@keithralphs keithralphs merged commit 0eea32e into main May 21, 2024
11 checks passed
@keithralphs keithralphs deleted the mirr_ser branch May 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running count plan against i22 HFM/VFM gives serialization error
2 participants