Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise slits #557

Closed
wants to merge 2 commits into from
Closed

Rationalise slits #557

wants to merge 2 commits into from

Conversation

olliesilvester
Copy link
Collaborator

Fixes #462

Blocked until i03's slit PV's use American English (centre and not center)

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly

@olliesilvester olliesilvester mentioned this pull request May 20, 2024
Draft
@dperl-dls
Copy link
Collaborator

Closing as stale, please feel free to reopen if this is still needed

@dperl-dls dperl-dls closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rationalise Slits Implementations
2 participants
@olliesilvester @dperl-dls