Add ability to enable dev shm streaming on eiger #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
approved these changes
May 22, 2024
| @@ -144,6 +144,9 @@ def stop(self, *args): | |||
| self.disarm_detector() | |||
| stop_status &= self.disable_roi_mode() | |||
| stop_status.wait(self.GENERAL_STATUS_TIMEOUT) | |||
| # See https://github.com/DiamondLightSource/hyperion/issues/1395 | |||
| LOGGER.info("Turning off Eiger dev/shm streaming") | |||
There was a problem hiding this comment.
Nit: If we have enable_dev_shm set to off, I think we will get a logging message during change_dev_shm, and in Hyperion when XRC finishes, and again here - all saying that dev shm is being disabled
There was a problem hiding this comment.
I think that given the consequence of leaving it on accidentally is very bad it's actually good to be very specific in the logs that we're turning it off even if that doesn't actually matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DiamondLightSource/hyperion#1372
Instructions to reviewer on how to test:
Checks for reviewer