Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and rename attach metadata #590

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

callumforrester
Copy link
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@callumforrester callumforrester changed the title Fix attach metadata Move and rename attach metadata May 31, 2024
@stan-dot stan-dot self-assigned this Jun 3, 2024
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
@stan-dot
Copy link
Contributor

stan-dot commented Jun 3, 2024

@callumforrester does this need to be tested on the beamline before merging?

@callumforrester callumforrester marked this pull request as ready for review June 3, 2024 10:44
@callumforrester
Copy link
Contributor Author

@stan-dot No, an approval from someone either than the two of us is all that's needed

@callumforrester callumforrester merged commit 7feb460 into main Jun 4, 2024
11 checks passed
@callumforrester callumforrester deleted the fix-attach-metadata branch June 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants