Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test forgotten from #628 #645

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add test forgotten from #628 #645

merged 3 commits into from
Jun 26, 2024

Conversation

DominicOram
Copy link
Contributor

I wrote this at the time I wrote #628 but forgot to add it

Instructions to reviewer on how to test:

  1. Confirm new test passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram
Copy link
Contributor Author

Tests failing here are also failing on main so merging anyway

@DominicOram DominicOram merged commit 507f81c into main Jun 26, 2024
9 of 11 checks passed
@DominicOram DominicOram deleted the add_missing_test branch June 26, 2024 09:59
rtuck99 added a commit that referenced this pull request Jul 16, 2024
rtuck99 added a commit that referenced this pull request Jul 16, 2024
rtuck99 added a commit that referenced this pull request Jul 17, 2024
* Make ruff happy

* Revert "Add function to save a thumbnail"

This reverts commit 654205b.

* Revert "Add test forgotten from #628 (#645)"

This reverts commit 507f81c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants