Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

670 remove mockito #711

Merged
merged 6 commits into from
Jul 29, 2024
Merged

670 remove mockito #711

merged 6 commits into from
Jul 29, 2024

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Jul 29, 2024

Fixes #670
Removed mockito dependence.
During which I have to altered test_converter_eq() in test_converter_eq.py to match/improve coverage.

Instructions to reviewer on how to test:

  1. Run unit test
  2. Confirm all test passes.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (9bfa98f) to head (dc4e513).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   94.49%   94.51%   +0.02%     
==========================================
  Files         110      110              
  Lines        4376     4376              
==========================================
+ Hits         4135     4136       +1     
+ Misses        241      240       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram merged commit 1f7e9d2 into main Jul 29, 2024
18 checks passed
@DominicOram DominicOram deleted the 670-remove-mockito branch July 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mockito
2 participants