Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to zocalo interaction to enable containerisation #725

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Aug 6, 2024

Removes dependency on the system hostname from zocalo so that we can be run in a container

See DiamondLightSource/hyperion#1511

Instructions to reviewer on how to test:

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.43%. Comparing base (608d913) to head (b5a5d0d).
Report is 1 commits behind head on main.

Files Patch % Lines
src/dodal/devices/zocalo/zocalo_results.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   94.48%   94.43%   -0.06%     
==========================================
  Files         113      113              
  Lines        4571     4581      +10     
==========================================
+ Hits         4319     4326       +7     
- Misses        252      255       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtuck99 rtuck99 force-pushed the hyperion_1367_containerise_hyperion branch from 070e7d1 to ae41b3b Compare August 6, 2024 10:06
@rtuck99 rtuck99 marked this pull request as ready for review August 6, 2024 10:07
Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rtuck99 rtuck99 merged commit 1584542 into main Aug 15, 2024
16 of 18 checks passed
@rtuck99 rtuck99 deleted the hyperion_1367_containerise_hyperion branch August 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants