Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CTAB to ophyd_async #728

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Convert CTAB to ophyd_async #728

merged 4 commits into from
Aug 7, 2024

Conversation

olliesilvester
Copy link
Collaborator

Fixes #687

Instructions to reviewer on how to test:

  1. Check components have been changed to the correct type

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (5c8c4d7) to head (80f8fd5).

Files Patch % Lines
src/dodal/devices/CTAB.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   94.39%   94.31%   -0.09%     
==========================================
  Files         110      110              
  Lines        4392     4396       +4     
==========================================
  Hits         4146     4146              
- Misses        246      250       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olliesilvester
Copy link
Collaborator Author

This never had any tests since the device hasn't been used in bluesky yet, so I vote we ignore the CI

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@olliesilvester olliesilvester merged commit 6180033 into main Aug 7, 2024
16 of 18 checks passed
@olliesilvester olliesilvester deleted the make_ctab_ophyd_async branch August 7, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to ophyd-async: CTAB
3 participants