-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mx bluesky 135 stream to murko #733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 94.33% 94.41% +0.07%
==========================================
Files 111 112 +1
Lines 4469 4526 +57
==========================================
+ Hits 4216 4273 +57
Misses 253 253 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine for now. It could easily be a lot more generic if e.g. the stream url was configurable, and I wonder if the performance will always be good enough, but I think those are questions for later
Not sure what you mean here the URL is taken from the OAV. Do you mean make it generic to work with any given URL, even if it doesn't come from an OAV?
Yh, I've done no performance testing. Works for this use case though |
Fixes DiamondLightSource/mx-bluesky#135
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}