Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mx bluesky 135 stream to murko #733

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Aug 7, 2024

Fixes DiamondLightSource/mx-bluesky#135

Instructions to reviewer on how to test:

  1. Compare against docs in mx_bluesky and confirm behavior makes sense
  2. Confirm unit tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (b88c415) to head (3c8c64e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   94.33%   94.41%   +0.07%     
==========================================
  Files         111      112       +1     
  Lines        4469     4526      +57     
==========================================
+ Hits         4216     4273      +57     
  Misses        253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for now. It could easily be a lot more generic if e.g. the stream url was configurable, and I wonder if the performance will always be good enough, but I think those are questions for later

@DominicOram
Copy link
Contributor Author

the stream url was configurable,

Not sure what you mean here the URL is taken from the OAV. Do you mean make it generic to work with any given URL, even if it doesn't come from an OAV?

and I wonder if the performance will always be good enough, but I think those are questions for later

Yh, I've done no performance testing. Works for this use case though

@DominicOram DominicOram merged commit e19bf47 into main Aug 9, 2024
18 checks passed
@DominicOram DominicOram deleted the mx_bluesky_135_stream_to_murko branch August 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I04: Stream data into murko whilst thawing
2 participants