Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading grid scan information #50

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Add support for reading grid scan information #50

merged 5 commits into from
Oct 5, 2018

Conversation

Anthchirp
Copy link
Contributor

@Anthchirp Anthchirp commented Oct 5, 2018 •
edited
Loading

@Anthchirp
Add function to retrieve grid scan information
4d85b59 
Fixes MXSW-1173.
@Anthchirp
Update object model to retrieve gridinfo
9cd501e
@Anthchirp
Update connection test
ed8ae02 
update the test to explicitly use the __future__ connection now that
.gridinfo no longer implicitly requires the __future__ interface.
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 79.239% when pulling ed8ae02 on MXSW-1173 into 529fcd1 on master.

@coveralls
Copy link

coveralls commented Oct 5, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 83.088% when pulling 4dd771b on MXSW-1173 into 529fcd1 on master.

@Anthchirp
Change call to follow convention
62fc0a7 
to use keyword arguments.
KarlLevik
KarlLevik reviewed Oct 5, 2018
View reviewed changes
Copy link
Member

@KarlLevik KarlLevik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for that method name 👍
Edit: Looks good now!

ispyb/sp/mxacquisition.py Outdated Show resolved Hide resolved
@Anthchirp
Change method name
4dd771b 
as requested. Also add test for GridInfoId.
@KarlLevik
Copy link
Member

👍

@Anthchirp Anthchirp merged commit 37f2ed9 into master Oct 5, 2018
@Anthchirp Anthchirp deleted the MXSW-1173 branch October 5, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlLevik KarlLevik KarlLevik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anthchirp @coveralls @KarlLevik