Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor murfey.server.api into submodules #328

Closed
tieneupin opened this issue Aug 9, 2024 · 0 comments · Fixed by #321
Closed

Refactor murfey.server.api into submodules #328

tieneupin opened this issue Aug 9, 2024 · 0 comments · Fixed by #321
Assignees
Labels
server Relates to the server component

Comments

@tieneupin
Copy link
Contributor

tieneupin commented Aug 9, 2024

Currently, the main API module murfey.server.api has exceeded 1600 lines, and API endpoints for auth, clem, and spa are stored separately in their own sub-folders.

I suggest refactoring the API endpoints to take the following file structure as an attempt to improve organisation:

src/murfey
|__ server
    |__ api
        |__ __init__.py  <- Stores unsorted API endpoints from what was formerly 'murfey/server/api.py'
        |__ auth.py
        |__ clem.py
        |__ spa.py
        |__ ...  <- We can slowly migrate items from the __init__.py file based on themes
@tieneupin tieneupin added the server Relates to the server component label Aug 9, 2024
@tieneupin tieneupin changed the title Refactoring murfey.server.api into submodules Refactor murfey.server.api into submodules Aug 14, 2024
@tieneupin tieneupin self-assigned this Oct 1, 2024
@tieneupin tieneupin linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Relates to the server component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant