Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup existing argo workflows postgres secret before generating anew #92

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

garryod
Copy link
Member

@garryod garryod commented Jul 24, 2024

Checks for the existence of a argo workflows postgres passwords secret instead of relying on the helm .Release.isUpgrade value to determine whether a new password should be generated. This should resolve the issue in which the Argo Workflows server gets a new password but the one in the database remains

@garryod garryod added bug Something isn't working helm Pull request that updates Helm charts labels Jul 24, 2024
@garryod garryod requested a review from daurer July 24, 2024 12:22
@garryod garryod self-assigned this Jul 24, 2024
@garryod garryod force-pushed the avoid-recreating-argo-workflows-postgres-secret branch from 0f1acf1 to f18c656 Compare July 25, 2024 08:04
Co-authored-by: Benedikt Daurer <benedikt.daurer@diamond.ac.uk>
@garryod garryod force-pushed the avoid-recreating-argo-workflows-postgres-secret branch from f18c656 to a77571e Compare July 25, 2024 08:08
@garryod garryod marked this pull request as ready for review July 25, 2024 08:24
@garryod garryod merged commit 4eb8528 into main Jul 25, 2024
21 checks passed
@garryod garryod deleted the avoid-recreating-argo-workflows-postgres-secret branch August 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm Pull request that updates Helm charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants