Feature/#docker file #106
Closed
Feature/#docker file #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Mihir, Thanks for raising the PR. A dockerfile has already been added to the repository. Ref: https://github.com/DiceDB/dice/blob/master/Dockerfile Hence. closing the PR. If you think we can do better with the existing Dockerfile, do raise a PR happy to incorporate the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updated the DockerFile with multistage docker build which produces low-sized docker images and only builds linux distribution-based executable.
Tests:
Manually tested by running docker and connecting it via redis-cli and tested basic commands.
BUILD Image: docker build -t image_name .
RUN Command: docker run -p 7379:7379 image_name