39 : Add PR template #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arpitbbhayani , @rohanverma94 , please take a look at this PR when you have time. |
yashs360
reviewed
Jul 11, 2024
| ## Type of Changes | ||
| - [ ] New Feature | ||
| - [ ] Bug-fix | ||
| - [ ] Enhancement |
There was a problem hiding this comment.
Looks ok to me. Enhancement feels a little open-ended and i am afraid everyone will start using this category for everything.
I would also like to think why are we creating this template. I personally think this data should help the reviewers with PR review prioritisation. Any other data/info we need here that will help with prioritisation?
yashs360
reviewed
Jul 11, 2024
| - [ ] Tests | ||
|
|
||
| ## Test Results | ||
| - Results of tests done (manual or automated) to verify the changes made. |
There was a problem hiding this comment.
Since we are a system where performance and memory foot print is critical, i would like to see a section on "benchmark results". How easy is it for us to run benchmark on new features atm? @JyotinderSingh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39
Summary
Type of Changes
Checklist