extract Subscriber API into interface #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @author Wolfgang Schmiesing (P224488, IT.IN.FRW) | ||
| * @author Christian Schlichtherle | ||
| */ | ||
| public final class DefaultSubscriber implements Subscriber { |
There was a problem hiding this comment.
This class should be package private. Clients should only depend on the Subscriber interface.
| * es andernfalls zu Datenverlust kommt! | ||
| * Es wird daher empfohlen, die erneuerbaren Ausgabeströme nur in <i>try-with-resources</i>-Anweisungen zu benutzen. | ||
| */ | ||
| public SeconCallable<OutputStream> signAndEncryptTo( |
There was a problem hiding this comment.
Once the class is package private, this documentation should be removed.
added 2 commits
October 13, 2020 13:26
christian-schlichtherle
approved these changes
Oct 13, 2020
| * Zeigt an, dass das im SECON-Kontext {@linkplain Subscriber#certificate() konfigurierte Zertifikat} zu keinem der | ||
| * vorgesehenen Empfänger einer verschlüsselten Nachricht passt und die Nachricht daher nicht entschlüsselt werden kann. | ||
| * Eine Instanziierung dieser Klasse außerhalb dieses Pakets ist nicht möglich. | ||
| * Zeigt an, dass das im SECON-Kontext {@linkplain DefaultSubscriber#certificate() konfigurierte Zertifikat} zu keinem |
There was a problem hiding this comment.
Diese Methode gibt es nicht (mehr).
loetifuss
added a commit
to loetifuss/kks-encryption
that referenced
this pull request
Oct 27, 2020
Merge pull request DieTechniker#28 from loetifuss/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for cleaner dependency handling the implementation code of Subscriber has been moved to DefaultSubscriber. Clients should only program against the interfaces so they don't need to bother about compile time dependencies to other libraries.