-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatible with .NET Core 3.1? #373
Comments
I have just tried to set up a fresh project. For me it does not compile at
|
Tomorrow i will publish new version with support 3.1 to nuget |
I am using 1.0.0-alpha3, with an out of the box brand new project. Following the instructions in the readme, I get this: System.InvalidOperationException: 'Unable to find the required services. Please add all the required services by calling 'IServiceCollection.AddRouting' inside the call to 'ConfigureServices(...)' in the application startup code.' All I am doing in ConfigureServices is:
Where WeatherService is just a class that returns a string. |
@snapfisher Hi, maybe need add to Startup UseRouting and UseEndpoints calls? public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
{
app.UseRouting();
app.UseEndpoints(endpoints => {
endpoints.UseSoapEndpoint<ServiceContractImpl>("/ServicePath.asmx", new BasicHttpBinding());
});
} |
I already did that. I went back to the README and followed it exactly. Although, for ServiceContractImpl, I used the interface, not the service. Reading it now, maybe it should have been the other way around. I'll check it later today. Other than that, it matched the instructions. |
Hi @kotovaleksandr, I have one problem with DeserializeInputParameter. In the previous version (0.9.9.6) stable worked Deserialize, the current version works wrong. There is a problem with namespaces object. After I analyzed your code, I found the problem:
version 1.0.0:
If we have different namespaces contract and object which we want deserialize, our object will not deserialized. And we get request with null. |
Hi @BorisVezhyk. Can you describe your model? Service have one namespace, but method arguments model another namespace? This problem not related to .NET Core 3.x, its application code issue. |
I changed the call to use the service directly, and it still fails. It fails here:
And for completeness, my entire Startup.cs file looks like this: namespace WeatherSoapApi
} |
@snapfisher enable MVC in ConfigureServices: services.AddMvc(); |
That does not fix the problem. I tried in all three positions in the method. I get this failure from SoapCore. It seems to start fine, the failure is when I try and hit http://localhost:port/ServicePath.asmx. I tried with Kestral and IIS Express. Image of the stack trace on failure.... |
@snapfisher Your service interface have ServiceContract attribute? |
@kotovaleksandr I need to create a new service, but it must work with old working clients. And clients send the next xml request. For example,
I use the next contract.
And it works in 0.9.9.6 and mapping correct, but does not work in 1.0.0.... So, I found one more problem with deserializing base64 string in 1.0.0.0(( |
@BorisVezhyk Boris, please, create two issues: about problem with namespaces (i'm already reproduce this problem, work in progress) and about base64 string. |
I created the second issue here #380. and described where a problem. |
For me alpha3 works fine in the new clean project. Thanks a lot Alexander. |
SampleService already have attributes: |
Missed the interface. All is perfect. Thanks. |
does it required in .net core 3.1? |
We've just updated our project from 2.2 to 3.1 as it's the LTS version, and all our responses are now coming back empty:
<s:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
<s:Body />
</s:Envelope>
No errors or exceptions, just empty. I can see the custom response being correctly built up, but by the time the IMessageInspector2.BeforeSendReply() gets it, the reply is empty, as above.
The text was updated successfully, but these errors were encountered: