Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to not normalize newlines #1024

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

vidrenning
Copy link
Contributor

The XmlWriter that is used by SoapCore to write the SOAP XML responses for all requests will by default normalize newlines in the generated XML responses.

This means that for a string that contains LF ('\n') newlines, these newlines will automatically be converted to CRLF ("\r\n").

This is different from the behavior of the old ASMX Web Services, which will not normalize the newlines.

I have added a new option that controls whether the newlines should be normalized or not. The default behavior is "true", so the commit will not change the behavior for existing users of SoapCore.

@andersjonsson
Copy link
Collaborator

Seems like a good thing. Thanks!

@andersjonsson andersjonsson merged commit ea8e033 into DigDes:develop Feb 27, 2024
3 checks passed
@vidrenning vidrenning deleted the normalizenewlines branch February 27, 2024 08:59
@vidrenning
Copy link
Contributor Author

Thanks for merging! Would it be possible to build a new NuGet version again? Thank you for all your work on maintaining SoapCore! 🙂

@andersjonsson
Copy link
Collaborator

Nuget package on the way.

The new package also includes a change to avoid blocking when the request-message is read. Reading will now take longer and use more memory but hopefully the overall throughput is increased. If you notice performance regressions please submit an issue

@vidrenning
Copy link
Contributor Author

Thank you, appreciate it! I will let you know if I notice any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants