-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Content-Length header in response #843
Conversation
Reduced build warnings Added Custom string writer fixing a test case
@andersjonsson Can you approve the Github actions (Pipelines)? |
Thanks for the PR! |
Thanks. I Will also look at the CodeQL failure later on this week.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few notes.
@acveigas Damn, I need to learn to read better 😆 I thought you changed Content-Length to the number of bytes. Try sending a character that is represented by two bytes, like ü or é. Maybe your legacy client will accept whatever in the header, but I think the correct behavior would be to set the header to the number of bytes. What do you think? |
I can send a PR with number of bytes. Shouldn't take time 😊 |
Thanks! |
Came across few SOAP clients which require Content-Length header to be set in order for the SOAP request to go through.
Without this change, Content-Length header is not set and Transfer-Encoding is chunked