fix: sample size validation added

Bloomstack · Aug 26, 2020 · faf31e2 · faf31e2
1 parent 2bda676
commit faf31e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/erpnext/public/js/utils.js b/erpnext/public/js/utils.js
@@ -749,6 +749,11 @@ $(document).on('app_ready', function() {
 											],
 											primary_action: function () {
 												const values = dialog.get_values().items;
+												values.forEach(item=>{
+													if(item.qty < item.sample_size) {
+														frappe.throw(__("Row #{0}: The sample size: {1} should be less than available qty: {2}", [item.idx, item.sample_size, item.qty]));
+													}
+												})
 												frappe.call({
 													method: "erpnext.stock.doctype.quality_inspection.quality_inspection.make_quality_inspections",
 													freeze: true,

diff --git a/erpnext/stock/utils.py b/erpnext/stock/utils.py
@@ -386,6 +386,7 @@ def validate_quality_inspection_item(doc, items):
 				"reference_name": item.get("parent"),
 				"item_code": item.get("item_code"),
 				"item_name": item.get("item_name"),
+				"qty": item.get("qty"),
 				"inspection_type": inspection_type_map[doc.get("doctype")][0]
 			})
 	return data