Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make Quality Inspection from Purchase receipt, Delivery Note and Stock Entry Added #453

Merged
merged 11 commits into from
Aug 28, 2020
Merged

feat: Make Quality Inspection from Purchase receipt, Delivery Note and Stock Entry Added #453

merged 11 commits into from
Aug 28, 2020

Conversation

vishdha
Copy link

@vishdha vishdha commented Jul 30, 2020 •
edited
Loading

Task ID: https://bloomstack.com/desk#Form/Task/TASK-2020-01134

  • Make QI from Purchase Receipt

  • Make QI form Stock Entry

  • Make QI form Delivery Note

  1. Make Quality Inspection from Purchase Receipt
    Peek 2020-07-30 17-06

@vishdha vishdha marked this pull request as ready for review July 31, 2020 04:28
Alchez
Alchez suggested changes Jul 31, 2020
View reviewed changes
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/stock/doctype/quality_inspection/quality_inspection.py Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
Alchez
Alchez suggested changes Jul 31, 2020
View reviewed changes
erpnext/stock/doctype/quality_inspection/quality_inspection.py Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
@Alchez
Copy link

Alchez commented Jul 31, 2020

@vishdha, you'll have to pull in @bhattdevarsh's changes in the QI doctype

@vishdha vishdha changed the base branch from bloomstack-v12-staging to staging August 13, 2020 09:08
Alchez
Alchez suggested changes Aug 13, 2020
View reviewed changes
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
Alchez
Alchez suggested changes Aug 13, 2020
View reviewed changes
Copy link

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should edit the dashboard too for linking QIs. Currently, it links them using the QI field inside the items table.

image

erpnext/stock/doctype/quality_inspection/quality_inspection.py Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
erpnext/stock/doctype/quality_inspection/quality_inspection.py Show resolved Hide resolved
erpnext/stock/doctype/quality_inspection/quality_inspection.py Show resolved Hide resolved
erpnext/stock/doctype/quality_inspection/quality_inspection.py Outdated Show resolved Hide resolved
erpnext/public/js/utils.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1917

  • 3 of 19 (15.79%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
erpnext/stock/doctype/quality_inspection/quality_inspection.py 2 8 25.0%
erpnext/stock/utils.py 1 11 9.09%
Totals Coverage Status
Change from base Build 1885: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@vishdha vishdha changed the title feat: Make Quality Inspection from Purchase receipt Added feat: Make Quality Inspection from Purchase receipt, Delivery Note and Stock Entry Added Aug 19, 2020
@Alchez Alchez merged commit cde8bbf into Bloomstack:staging Aug 28, 2020
@Alchez Alchez deleted the TASK-2020-01134-1 branch August 28, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alchez Alchez Alchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishdha @Alchez @coveralls