Sticky parameter to header builder #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall I include #181 as well? |
|
Thanks for contribution. Same functionality is added in #126, so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion to enable styling the sticky and the non-sticky headers differently. Currently, the background can be specified for the sticky ones but there might be cases when more than the background (eg. foreground, font style, etc) needs to be different as well. The perfect solution would be to modify
groupSeparatorBuilder()to include thestickyparameter but that would be a breaking change. So, I added a new builder callback. If you consider this approach acceptable, you might want to deprecate the orginal one some time in the future.