python/ftp - Hotfix FTPDataConnect.__init__ requiring defaults for args #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the community and thanks for opening your first pull request. Feel free to look for more issues to tackle at https://github.com/DinoTools/dionaea/issues |
PaulosV
changed the title
|
Thanks for your contribution. I will have a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Fixes #324. Adds dummy defaults to the FTPDataConnect constructor, as required by PR #318 (commit acc8bc8)
I was thinking about adding further sanity checks for the values, but then I checked the fix in the PR and it seems adequate to leave it like it is now.