This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
dioxus create some_project
now actually creates said project
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issues #93 and (partially) #94.
Logic in DioxusConfig::load() was requiring the presence of a cargo crate before actually running the project creation flow; this prevented running
dioxus create some_project
in any arbitrary directory, and created a sub-crate inside cargo crate directories (which is, presumably, not desired behavior).By catching the crate_root error raised in ::load() when running outside of a crate, we enable the creation of new projects from scratch, e.g.:
Also added some grammar fixes.