-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cargo Arguments and Cross-Architecture Support #1777
Conversation
Previously only the top-level error was shown, giving only vague data for debugging the build process
We can use the target flag for the target triple for parity with the cargo commands. It is breaking, but it would make it a lot easier to use coming from cargo. |
I've removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this changes the --target
arg, but because that argument did nothing, I think it is OK to make that change in a minor release.
Thank you!
Changes apply for the CLI actions
build
,bundle
, andserve
. Adds-- [CARGO_FLAGS]
and--platform-triple
.Cargo arguments can now be passed through after
--
(e.g.dx build -- --timings
) via escaped conditionals. This does lock out that space for any later usage without a breaking change to the CLI, but I can't think of any other necessary use for post-argument parsing on this tool.Since the
--target
flag is currently taken, a--platform-triple
flag allows alternative values forcargo build --target
. This can't be done directly in passthrough, since dioxus-cli needs to know the output folder. If reasonable, the existing--target
flag should probably be renamed so we can be 1:1 with cargo naming.If the codebase has any other instances where bundled anyhow errors are flattened by "{}" they should probably be replaced with "{:?}" or "{:#?}" -- this caused a lot of confusion trying to bundle my first Dioxus project.
Closes #1693, closes #1347