Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only subscribe scopes to signals when rendering #1933

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

ealmloff
Copy link
Member

Closes #1930

@ealmloff ealmloff added bug Something isn't working signals Related to the signals crate labels Feb 14, 2024
@ealmloff ealmloff marked this pull request as ready for review February 14, 2024 17:40
@ealmloff
Copy link
Member Author

I restored the signal tests which are failing because of #1935

@jkelleyrtp jkelleyrtp merged commit 1145ed7 into DioxusLabs:master Feb 14, 2024
9 checks passed
@ealmloff ealmloff deleted the restore-rendering-check branch February 14, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working signals Related to the signals crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Scopes get subscribed when signals are read inside event handlers
2 participants