-
-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward cli serve settings and make it easier to provide platform config to fullstack #2521
Merged
jkelleyrtp
merged 20 commits into
DioxusLabs:main
from
ealmloff:forward-cli-serve-settings
Jun 28, 2024
Merged
Forward cli serve settings and make it easier to provide platform config to fullstack #2521
jkelleyrtp
merged 20 commits into
DioxusLabs:main
from
ealmloff:forward-cli-serve-settings
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
enhancement
New feature or request
breaking
This is a breaking change
fullstack
related to the fullstack crate
labels
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This is a breaking change
enhancement
New feature or request
fullstack
related to the fullstack crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards settings from
dx serve
to fullstack. This makes theport
andopen
arguments work with fullstack applications. Closes #2380It also makes it slightly easier to provide platform specific context to fullstack. You can now provide platform specific configs, and fullstack will combine them into the fullstack config automatically:
Stacked on #2517, #2515