Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward cli serve settings and make it easier to provide platform config to fullstack #2521

Merged
merged 20 commits into from
Jun 28, 2024

Conversation

ealmloff
Copy link
Member

This PR forwards settings from dx serve to fullstack. This makes the port and open arguments work with fullstack applications. Closes #2380

It also makes it slightly easier to provide platform specific context to fullstack. You can now provide platform specific configs, and fullstack will combine them into the fullstack config automatically:

LaunchBuilder::new()
        .with_cfg(web!(
            dioxus::web::Config::new().with_default_panic_hook(false)
        ))
        .with_cfg(server_only!(dioxus::fullstack::ServeConfig::builder()
            .incremental(IncrementalRendererConfig::default())))
        .launch(app)

Stacked on #2517, #2515

@ealmloff ealmloff added enhancement New feature or request breaking This is a breaking change fullstack related to the fullstack crate labels Jun 14, 2024
@jkelleyrtp jkelleyrtp merged commit ffa36a6 into DioxusLabs:main Jun 28, 2024
10 checks passed
@ealmloff ealmloff deleted the forward-cli-serve-settings branch August 12, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change enhancement New feature or request fullstack related to the fullstack crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning a port number when using dx serve --port [number] on fullstack is not respected.
2 participants