Add support for align-items: space-evenly #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Aug 22, 2022
TimJentzsch
reviewed
Aug 22, 2022
Weibye
suggested changes
Aug 22, 2022
Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
nicoburns
force-pushed
the
add-flexbox-align-content-space-evenly-support
branch
from
16a3dbb
to
62e7432
Compare
|
Comments addressed, and rebased on top of latest main |
TimJentzsch
approved these changes
Aug 23, 2022
nicoburns
added a commit
to nicoburns/taffy
that referenced
this pull request
Aug 23, 2022
* Add support for align-items: space-evenly * Add AlignContent::SpaceEvenly to RELEASES.md * Fix typo in AlignContent doc comments (gap -> gaps) Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com> * Fix align_content_space_around_single_line test Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Add support for align-items: space-evenly * Add AlignContent::SpaceEvenly to RELEASES.md * Fix typo in AlignContent doc comments (gap -> gaps) Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com> * Fix align_content_space_around_single_line test Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
align-contenthas aspace-evenlyvalue in the CSS spec (see: https://developer.mozilla.org/en-US/docs/Web/CSS/align-content). This PR implements that value. For some reason we were already supporting it injustify-contentbut notalign-contenteven though the spec defines it for both and the implementation is pretty simple.Context
This is required for CSS Grid, but is a valid improvement in its own right so submitting separately.