Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is to more closely align our naming with the spec:
MaxTrackSizingFunction::Flex
toMaxTrackSizingFunction::Fraction
flex()
helper tofr()
flex()
that resolves tominmax(0px, Nfr)
The unit is called
fr
in the spec (although it does also talk about "flexible track sizing functions".The
flex()
helper is to try to encourage people to useminmax(0px 1fr)
- this is much faster than plain1fr
as it doesn't have to do any content sizing. Hopefully the pattern for "4 evenly sized tracks" can be something like:although the following would also work and be just as effcient
Feedback wanted
Does this naming make sense?
EDIT: Would it perhaps be better to leave the naming as it is and create an
evenly_sized_tracks(count: u16)
helper that directly creates arepeat(4, flex(1.0))
?