Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for content alignment spec updates #635

Merged
merged 4 commits into from
May 13, 2024

Conversation

nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Apr 3, 2024

Objective

The spec for fallback content alignment (in the case that the content overflows it's container) has changed. Rather than laying out content at a negative offset where it cannot be viewed it now falls back to safe start alignment. This PR is designed to update Taffy to match the new spec.

Todo

  • Update gentests for Chrome 123
  • Fix default alignment

Context

@nicoburns nicoburns changed the title Content alignment updates Fixes for Content Alignment updates May 13, 2024
@nicoburns nicoburns changed the title Fixes for Content Alignment updates Fixes for Content Alignment spec updates May 13, 2024
@nicoburns nicoburns changed the title Fixes for Content Alignment spec updates Fixes for content alignment spec updates May 13, 2024
@nicoburns nicoburns marked this pull request as ready for review May 13, 2024 12:35
@nicoburns nicoburns merged commit 04e20d1 into DioxusLabs:main May 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant