Skip to content

Add contents_url to PullRequestFile #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

Add contents_url to PullRequestFile #159

merged 1 commit into from
Aug 27, 2019

Conversation

jmagman
Copy link
Contributor

@jmagman jmagman commented Aug 27, 2019

Fixes #158.

tvolkert
tvolkert approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pacane @robbecker-wf any chance of publishing a 5.1.0 release that includes this fix?

@robbecker-wf robbecker-wf merged commit ecc946e into SpinlockLabs:master Aug 27, 2019
@tvolkert
Copy link
Contributor

Thanks!

@jmagman
Copy link
Contributor Author

jmagman commented Aug 27, 2019

Thank you!

@jmagman jmagman deleted the content-url branch August 27, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbecker-wf robbecker-wf robbecker-wf approved these changes

+1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PullRequestFile is missing contents_url
3 participants
@jmagman @tvolkert @robbecker-wf