-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes when clicking any FAB option under Contacts->Connections #407
Comments
Hi @zdmc23 see the following video with the fix: https://drive.google.com/file/d/1cQ_ShtQtwM6RmY7YYYpyNvkM3UhurUpD/view?usp=sharing |
Merged
zdmc23
added a commit
that referenced
this issue
Sep 2, 2020
zdmc23
added a commit
that referenced
this issue
Sep 16, 2020
* Adding missing icons to fields Adding missing icons to fields on contact details, edit and new screens. * FAB action colors giving the fab actions a different color to help quickly identify each action. * Add initial comment icon * reformatting Icon code for consitency * fix icon from user to users for group edit screen on the group edit screen it used incorrectly a singular icon for group name instead of the group icon. And minor code cleanup. * Add new group icons Group name and Group type * import status icon; remformatted code identations * Adding status icons to contacts and group screens * resolves #259 and adds colors to icons * styling for addIcons & removeIcons * added icon for milestone Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone". * added fieldsIcons style fieldsIcons: { height: 20, width: 20, }, * minor sizing adjustments to the icons * Resolve #407 * Resolves #424 * refinements to remove code conflicts * fix for church_start_date bad alignment * Resolve #405 Co-authored-by: Mike Allbutt <yo@ur.id.au> Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com>
zdmc23
added a commit
that referenced
this issue
Sep 20, 2020
* Bump to 1.7 * resolves #411 notifications screen: changed the separator from being | to ~ * Resolves #329 * Resolves #335 - Initial version of support for Questionnaire Plugin * Resolves #304 * Resolves #304 * Resolves #417 * Resolves #407 - Reintroduce Hans PR #438 * Resolves #424 - Reintroduces Hans PR #438 * Temporarily remove Sentry (see #438) * Significant UI fixes (#442) Resolves #259 * Manually fix security vulnerabilities in dependencies * Resolves #408 - specify utc() when displaying date (view mode) per DatePicker fields * Sprint 26 (#446) * Adding missing icons to fields Adding missing icons to fields on contact details, edit and new screens. * FAB action colors giving the fab actions a different color to help quickly identify each action. * Add initial comment icon * reformatting Icon code for consitency * fix icon from user to users for group edit screen on the group edit screen it used incorrectly a singular icon for group name instead of the group icon. And minor code cleanup. * Add new group icons Group name and Group type * import status icon; remformatted code identations * Adding status icons to contacts and group screens * resolves #259 and adds colors to icons * styling for addIcons & removeIcons * added icon for milestone Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone". * added fieldsIcons style fieldsIcons: { height: 20, width: 20, }, * minor sizing adjustments to the icons * Resolve #407 * Resolves #424 * refinements to remove code conflicts * fix for church_start_date bad alignment * Resolve #405 Co-authored-by: Mike Allbutt <yo@ur.id.au> Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com> * Resolves #403 - Group FAB button \(temporarily Comments only until D.T is ready with Activities) * Resolves #447 - case-insensitive comment authorship check * Icons and UIX adjustments (#449) * group date icons using fonts replaced the icons to use fonts * Swapping icons & adjusting spacings assigned_to and subassigned now use the same icons as the website; contact relation icon better represents what the field relats to; * FAB icon bottom padding Increased so that the FAB does not block the last items on the screen. * Include support for Serbian, Slovenian, and Croatian languages; updates to existing languages files * Include new languages in Moment to handle TZ; update language labels * Ui comments - edit and delete for contacts and groups (#451) * Reduced icon sizes & aligned vertically * Modifying the Delete & Edit buttons * Re-inserted the "editComment" and "deleteComment" lines * "delete" added to the language files added "delete" and used the existing text from the "deleteComment" translation - becuase it should be the same. * Fix some RTL layouts on Contact Details * RTL - fixes for text that was incorrectly aligning to the left and not right (#453) * aligned text to right if RTL URL and username field now align right when RTL is set. This also address an issue with #372 by reducing the height of the DT logo. * aligned text in connections fields * added this.props.isRTL to various fields * aligning fields in group record * aligning the lists The text of list items now correctly align to the left or right, depending on the language direction. * Fix text layout issue for iOS, and accomodate for "notch" per logo * minor design adjustments (#454) * Resolves #455 - Do not show FAB button in Edit Mode Co-authored-by: Mike Allbutt <yo@ur.id.au> Co-authored-by: Hans Rasch <raschdiaz@gmail.com> Co-authored-by: MexSurfer <43966676+mikeallbutt@users.noreply.github.com>
zdmc23
added a commit
that referenced
this issue
Sep 24, 2020
* Adding missing icons to fields Adding missing icons to fields on contact details, edit and new screens. * FAB action colors giving the fab actions a different color to help quickly identify each action. * Add initial comment icon * reformatting Icon code for consitency * fix icon from user to users for group edit screen on the group edit screen it used incorrectly a singular icon for group name instead of the group icon. And minor code cleanup. * Add new group icons Group name and Group type * import status icon; remformatted code identations * Adding status icons to contacts and group screens * resolves #259 and adds colors to icons * styling for addIcons & removeIcons * added icon for milestone Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone". * added fieldsIcons style fieldsIcons: { height: 20, width: 20, }, * minor sizing adjustments to the icons * Resolve #407 * Resolves #424 * refinements to remove code conflicts * fix for church_start_date bad alignment * Resolve #405 * Resolves #375 * Resolves #416 * Resolves #416 * Resolves #375 * Resolves #366 * Remove console log * Merge fix Co-authored-by: Mike Allbutt <yo@ur.id.au> Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed on iOS 13.6
App crashes when clicking any FAB option under Contacts->Connections
Steps to reproduce:
Test of issue 397 @854pm
Connections
FAB
and select any optionThe text was updated successfully, but these errors were encountered: