Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group leader footprint icon is staying activated #424

Closed
mikeallbutt opened this issue Aug 22, 2020 · 2 comments
Closed

Group leader footprint icon is staying activated #424

mikeallbutt opened this issue Aug 22, 2020 · 2 comments
Labels
bug Something isn't working
Milestone
Sprint 26

Comments

@mikeallbutt
Copy link
Collaborator

Incorrectly, the Group member leader icon (on a group members screen in edit mode) stays black after being inactivated.

  1. access a group record
  2. go to the members screen in edit mode
  3. (add a member if there are none)
  4. click the footprint icon to set that this contact is a leader.
  5. press the icon again - but it stays black (and not grey like it should)
  6. click save
  7. return to edit mode and the members screen
  8. press the footprint icon - and still the icon stays grey and not black.

Interestingly it seems that the leader is actually removed correctly even though the icon stays black.
@zdmc23 zdmc23 added the invalid This doesn't seem right label Aug 26, 2020
@zdmc23 zdmc23 added this to the Post-MVP milestone Aug 26, 2020
@zdmc23 zdmc23 added bug Something isn't working and removed invalid This doesn't seem right labels Aug 26, 2020
@zdmc23 zdmc23 modified the milestones: Post-MVP, Sprint 26 Aug 26, 2020
@zdmc23
Copy link
Collaborator

zdmc23 commented Aug 26, 2020

changing this to a bug and prioritizing it in the upcoming Sprint per @mikeallbutt

@raschdiaz-zz
Copy link
Contributor

Hi @mikeallbutt @zdmc23 We apply a fix to this: https://drive.google.com/file/d/1cgJ8hr56EifcrHb24gE1DyG2DWgHaiPt/view?usp=sharing

@raschdiaz-zz raschdiaz-zz mentioned this issue Sep 2, 2020
Merged
@zdmc23 zdmc23 closed this as completed in 1a69815 Sep 2, 2020
zdmc23 added a commit that referenced this issue Sep 2, 2020
@zdmc23
Resolves #424 - Reintroduces Hans PR #438
ae0ce99
zdmc23 added a commit that referenced this issue Sep 16, 2020
@raschdiaz @mikeallbutt @zdmc23
Sprint 26 (#446)
db6a4a9 
* Adding missing icons to fields

Adding missing icons to fields on contact details, edit and new screens.

* FAB action colors

giving the fab actions a different color to help quickly identify each action.

* Add initial comment icon

* reformatting Icon code for consitency

* fix icon from user to users for group edit screen

on the group edit screen it used incorrectly a singular icon for group name instead of the group icon.

And minor code cleanup.

* Add new group icons

Group name and Group type

* import status icon; remformatted code identations

* Adding status icons to contacts and group screens

* resolves #259 and adds colors to icons

* styling for addIcons & removeIcons

* added icon for milestone

Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone".

* added fieldsIcons style

fieldsIcons: {
    height: 20,
    width: 20,
  },

* minor sizing adjustments to the icons

* Resolve #407

* Resolves #424

* refinements to remove code conflicts

* fix for church_start_date bad alignment

* Resolve #405

Co-authored-by: Mike Allbutt <yo@ur.id.au>
Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com>
zdmc23 added a commit that referenced this issue Sep 20, 2020
@zdmc23 @mikeallbutt @raschdiaz
v1.7 Release (#456)
ab3bf0c 
* Bump to 1.7

* resolves #411

notifications screen: changed the separator from being | to ~

* Resolves #329

* Resolves #335 - Initial version of support for Questionnaire Plugin

* Resolves #304

* Resolves #304

* Resolves #417

* Resolves #407 - Reintroduce Hans PR #438

* Resolves #424 - Reintroduces Hans PR #438

* Temporarily remove Sentry (see #438)

* Significant UI fixes (#442)

Resolves #259

* Manually fix security vulnerabilities in dependencies

* Resolves #408 - specify utc() when displaying date (view mode) per DatePicker fields

* Sprint 26 (#446)

* Adding missing icons to fields

Adding missing icons to fields on contact details, edit and new screens.

* FAB action colors

giving the fab actions a different color to help quickly identify each action.

* Add initial comment icon

* reformatting Icon code for consitency

* fix icon from user to users for group edit screen

on the group edit screen it used incorrectly a singular icon for group name instead of the group icon.

And minor code cleanup.

* Add new group icons

Group name and Group type

* import status icon; remformatted code identations

* Adding status icons to contacts and group screens

* resolves #259 and adds colors to icons

* styling for addIcons & removeIcons

* added icon for milestone

Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone".

* added fieldsIcons style

fieldsIcons: {
    height: 20,
    width: 20,
  },

* minor sizing adjustments to the icons

* Resolve #407

* Resolves #424

* refinements to remove code conflicts

* fix for church_start_date bad alignment

* Resolve #405

Co-authored-by: Mike Allbutt <yo@ur.id.au>
Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com>

* Resolves #403 - Group FAB button \(temporarily Comments only until D.T is ready with Activities)

* Resolves #447 - case-insensitive comment authorship check

* Icons and UIX adjustments (#449)

* group date icons using fonts

replaced the icons to use fonts

* Swapping icons & adjusting spacings

assigned_to and subassigned now use the same icons as the website; contact relation icon better represents what the field relats to;

* FAB icon bottom padding

Increased so that the FAB does not block the last items on the screen.

* Include support for Serbian, Slovenian, and Croatian languages; updates to existing languages files

* Include new languages in Moment to handle TZ; update language labels

* Ui comments - edit and delete for contacts and groups (#451)

* Reduced icon sizes & aligned vertically

* Modifying the Delete & Edit buttons

* Re-inserted the "editComment" and "deleteComment" lines

* "delete" added to the language files

added "delete" and used the existing text from the "deleteComment" translation - becuase it should be the same.

* Fix some RTL layouts on Contact Details

* RTL - fixes for text that was incorrectly aligning to the left and not right (#453)

* aligned text to right if RTL

URL and username field now align right when RTL is set.

This also address an issue with #372 by reducing the height of the DT logo.

* aligned text in connections fields

* added this.props.isRTL to various fields

* aligning fields in group record

* aligning the lists

The text of list items now correctly align to the left or right, depending on the language direction.

* Fix text layout issue for iOS, and accomodate for "notch" per logo

* minor design adjustments (#454)

* Resolves #455 - Do not show FAB button in Edit Mode

Co-authored-by: Mike Allbutt <yo@ur.id.au>
Co-authored-by: Hans Rasch <raschdiaz@gmail.com>
Co-authored-by: MexSurfer <43966676+mikeallbutt@users.noreply.github.com>
zdmc23 added a commit that referenced this issue Sep 24, 2020
@raschdiaz @mikeallbutt @zdmc23
Sprint 27 (#462)
b12786b 
* Adding missing icons to fields

Adding missing icons to fields on contact details, edit and new screens.

* FAB action colors

giving the fab actions a different color to help quickly identify each action.

* Add initial comment icon

* reformatting Icon code for consitency

* fix icon from user to users for group edit screen

on the group edit screen it used incorrectly a singular icon for group name instead of the group icon.

And minor code cleanup.

* Add new group icons

Group name and Group type

* import status icon; remformatted code identations

* Adding status icons to contacts and group screens

* resolves #259 and adds colors to icons

* styling for addIcons & removeIcons

* added icon for milestone

Added around lines 3014 and 3100 the icon "Octicons" incon named "milestone".

* added fieldsIcons style

fieldsIcons: {
    height: 20,
    width: 20,
  },

* minor sizing adjustments to the icons

* Resolve #407

* Resolves #424

* refinements to remove code conflicts

* fix for church_start_date bad alignment

* Resolve #405

* Resolves #375

* Resolves #416

* Resolves #416

* Resolves #375

* Resolves #366

* Remove console log

* Merge fix

Co-authored-by: Mike Allbutt <yo@ur.id.au>
Co-authored-by: Zachary McCoy <191707+zdmc23@users.noreply.github.com>
@burr-road burr-road mentioned this issue Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 26
Development

No branches or pull requests
3 participants
@zdmc23 @raschdiaz-zz @mikeallbutt