Add missing params for threads without message #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanticc
requested changes
Mar 30, 2022
There was a problem hiding this comment.
I think it makes more sense to have a dedicated object for the Start Thread without Message endpoint.
And some fields are not mandatory so they need the Possible<T> type. The following fields should change their type:
StartThreadRequest
- auto_archive_duration
- rate_limit_per_user
StartThreadWithoutMessageRequest (new interface)
- auto_archive_duration
- type
- invitable
- rate_limit_per_user
SimonIT
force-pushed
the
threads-missing-params
branch
from
027010a
to
6f6282f
Compare
SimonIT
added a commit
to SimonIT/Discord4J
that referenced
this pull request
Mar 30, 2022
quanticc
added
field/addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/developers/docs/resources/channel#start-thread-without-message