Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AuditLog): add onboarding #1002

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open

feat(AuditLog): add onboarding #1002

wants to merge 74 commits into from
+172 −5

Conversation

Victorsitou
Copy link
Member

@Victorsitou Victorsitou commented Apr 8, 2023 •
edited
Loading

Summary

discord/discord-api-docs#6041
blocked by #928

I didn't add Server Guide types since that thing isn't documented yet.

Checklist

  • update docs
  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Victorsitou and others added 30 commits January 6, 2023 15:42
@Victorsitou
onboarding temp
40b1009
@Victorsitou
Merge branch 'onboarding-temp' into feat/guild-onboarding
037b858
@Victorsitou
fix
071c719
@Victorsitou
fix: remove onboarding edit
76a8911
@Victorsitou
feat: add new stuff
bbe55e9
@Victorsitou
feat: remove stuff
53a3f54
@Victorsitou
revert
292922f
@Victorsitou
remove unnecessary stuff
0d7313b
@Victorsitou
revert unnecessary stuff
183a6f6
@Victorsitou
2.8 -> 2.9
0b9ddd8
@Victorsitou
fix: tests
2f0b741
@Victorsitou
types
de1424c
@Victorsitou
feat: change the way emoji is handled
5f53a1f 
see d7d4d5bb08d0bba0760a001a80bce4745e441311
@Victorsitou
Merge remote-tracking branch 'upstream/master' into feat/guild-onboar…
4ba2bd4 
…ding
@Victorsitou
docs: change changelog name
a8fc694
@Victorsitou
fix: nox
a86e7e8
@Victorsitou
fix: docs
af3f09c
@Victorsitou
docs: this doesn't need permission
5c52ba9
@Victorsitou
get -> fetch
f57a29d
@Victorsitou
Merge remote-tracking branch 'upstream/master' into feat/guild-onboar…
2646122 
…ding
@Victorsitou
refactor: use emoji._to_partial().to_dict() instead
a7846ef
@Victorsitou
misc: remove some todos/notes
a62cd2a
@Victorsitou
fix: don't store useless id
7bce38c
@Victorsitou
fix: improve code
90d9813
@Victorsitou
feat: use Guild.get_channel instead of private attribute
cf92da3
@Victorsitou
feat: add roles and channels attributes to OnboardingPromptOption
2c704bd
@Victorsitou
tests: change OnboardingPrompt fixture
4b0f2b3
@Victorsitou
fix: this doesn't need state anymore
7e4998d
@Victorsitou
feat: remove useless x-super-properties
4659744
@Victorsitou @shiftinv
docs: apply suggestions
8782692 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou Victorsitou added t: enhancement New feature t: api support Support of Discord API features s: in progress Issue/PR is being worked on s: blocked Issue/PR is blocked by other issues s: needs review Issue/PR is awaiting reviews labels Apr 8, 2023
@onerandomusername
Copy link
Member

@Victorsitou would you please resolve conflicts?

@Victorsitou Victorsitou removed the s: blocked Issue/PR is blocked by other issues label Apr 22, 2023
shiftinv
shiftinv reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the PR!
I've got a few comments about documentation, and it would be great if you could update disnake.types.audit_log as well

disnake/enums.py Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Show resolved Hide resolved
disnake/audit_logs.py Outdated Show resolved Hide resolved
@Victorsitou Victorsitou added s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: in progress Issue/PR is being worked on labels Apr 25, 2023
shiftinv
shiftinv reviewed Apr 29, 2023
View reviewed changes
disnake/enums.py Outdated Show resolved Hide resolved
changelog/1002.feature.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
disnake/enums.py Show resolved Hide resolved
docs/api/audit_logs.rst Outdated Show resolved Hide resolved
Victorsitou and others added 4 commits April 29, 2023 12:06
@Victorsitou @shiftinv
docs: update
073ba88 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou @shiftinv
lint: lint
79c5a1d 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou
docs: update in_onboarding docs
c5dfd2c
@Victorsitou
docs: update new AuditLogAction\s in changelog
df9778c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victorsitou @onerandomusername @shiftinv