Support operator symbols that have the same semantics. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmascarenhas
force-pushed
the
operators-same-fn
branch
from
9b54e79
to
c7bc6e2
Compare
|
looks good to me. @fhackett, any comments? |
|
@mrordinaire Almost exactly what I had in mind when I left those comments - looks good to me. This did make me think of an incorrect behaviour in PGo's scoping rules though. See #74 for the (very specific and unlikely to show up in practice) details. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://lamport.azurewebsites.net/tla/summary.pdf