Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Management #3

Closed
bbengfort opened this issue May 18, 2016 · 4 comments
Closed

Style Management #3

bbengfort opened this issue May 18, 2016 · 4 comments
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: feature a new visualizer or utility for yb
Milestone

Comments

@bbengfort
Copy link
Member

bbengfort commented May 18, 2016

Create a scheme similar to Seaborn for creating a unified style and context system that sits on top of mpl.RCParams (so that every plot generated by our tool looks the same).

@bbengfort bbengfort added this to the Version 0.1 milestone May 18, 2016
@bbengfort bbengfort added type: feature a new visualizer or utility for yb priority: high should be done before next release ready labels May 18, 2016
@bbengfort bbengfort added the level: expert deep knowledge of packages required label Jun 1, 2016
@bbengfort
Copy link
Member Author

This task requires the ability to modify the visual environment in Yellowbrick similar to how Seaborn does it - but we're happy for ideas about how to do this in more innovative and intuitive ways. For lack of any ideas right now, I'll discuss Seaborn's:

  • set_style - set the color scheme and other color properties
  • set_context - set the font and size for 'talk', 'poster', 'paper', 'notebook', etc.

See: https://stanford.edu/~mwaskom/software/seaborn/tutorial/aesthetics.html for more.

We also want our own unique visual style that is clean like Seaborn without cloning it. We really like the idea of using Color Brewer as a foundation of our visualizations: https://bl.ocks.org/mbostock/5577023

@pvomelveny
Copy link
Contributor

Question:
Do we want Yellowbrick to blanket overwrite mpl defaults on import? It would then compete with Seaborn as well I think. Who ever gets imported last gets control of the style? (Actually it may make some kind of odd hybrid if we don't perfectly match the various Seaborn changes)

@bbengfort
Copy link
Member Author

It would be awesome to do an experiment about how the drawing environment
changes by mapping the global parameters (and a potential blog post). I
know I just said this outloud, but for the purposes of documentation:

  1. Modify the mpl defaults
  2. Visualize using striaght mpl
  3. Visualizing using pandas
  4. Visualize using seaborn
  5. set_context/set_style
  6. Visualize using straight mpl
  7. Visualize using pandas

And we can watch what is happening/changing.

@pvomelveny
Copy link
Contributor

Made a notebook with some quick experiments. Seems like most things are using the matplotlib rc settings that Seaborn creatively overwrites upon import.

Let me know if I missed anything obvious. Going to start copying over the Seaborn style functionality into Yellowbrick.

ojedatony1616 added a commit that referenced this issue Jun 4, 2016
Develop - Minimal Resolutions of Issues #3 and #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: feature a new visualizer or utility for yb
Projects
None yet
Development

No branches or pull requests

3 participants