Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Adds contest CRUD STUFF #65

Merged
merged 16 commits into from
Mar 10, 2016
Merged

Adds contest CRUD STUFF #65

merged 16 commits into from
Mar 10, 2016

Conversation

itsjoekent
Copy link
Contributor

What's this PR do?

Adds CRUD STUFF for Contests.

  • Index, show, update, delete. stuff

How should this be manually tested?

Pull the branch, can you view/make/edit/delete a contest?

Any background context you want to provide?

*CRUD STUFF is a highly technical term I learned from The Googles.

What are the relevant tickets?

Fixes #59

@itsjoekent
Copy link
Contributor Author

I think I will go back and add the more customy drop down thing we discussed in slack for setting the duration, I just wanted to first get the CRUD implemented to unblock all the other things

@itsjoekent
Copy link
Contributor Author

@weerd @sbsmith86 feel free to take a look when you get a chance

@@ -26,6 +26,10 @@
Route::model('competitions', 'Gladiator\Models\Competition');
Route::resource('competitions', 'CompetitionsController');

// Competitions
Route::model('contest', 'Gladiator\Models\Contest');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be plural to follow the other routes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also all of our views directories are plural as well (/views/competitions/, /views/waitingrooms/) so maybe update contests to be the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ill change it, as I pointed out to Diego 'ContestsController' just sounded funny to me for some reason #65 (comment)

@itsjoekent
Copy link
Contributor Author

@weerd good for re-review!

@angaither
Copy link
Contributor

stylezci

{
$contest = Contest::create($request->all());

return redirect()->action("ContestsController@show", $contest->id)->with('status', 'Contest has been saved!');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single quotes tho :nitpicky:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(diego i think you forgot to refresh 😉 )

@itsjoekent
Copy link
Contributor Author

@weerd HTML updated!


<div class="form-item -padded">
<label class="field-label" for="id">Campaign ID:</label>
<input type="number" name="campaign_id" id="campaign_id" class="text-field" placeholder="1234" value="{{ $contest->campaign_id or old('campaign_id') }}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is working correctly now? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💃

@weerd
Copy link
Contributor

weerd commented Mar 10, 2016

I think StyleCI is complaining cause there's extra tab spacing. Delete that and should be good!

@itsjoekent
Copy link
Contributor Author

DIEGO I DID IT YOURE A GENIUS

@weerd
Copy link
Contributor

weerd commented Mar 10, 2016

😉 👍

itsjoekent pushed a commit that referenced this pull request Mar 10, 2016
@itsjoekent itsjoekent merged commit 9e7a00b into master Mar 10, 2016
@itsjoekent itsjoekent deleted the contestcrud branch March 17, 2016 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants