Adds contest CRUD STUFF #65
Conversation
|
I think I will go back and add the more customy drop down thing we discussed in slack for setting the duration, I just wanted to first get the CRUD implemented to unblock all the other things |
|
@weerd @sbsmith86 feel free to take a look when you get a chance |
| @@ -26,6 +26,10 @@ | |||
| Route::model('competitions', 'Gladiator\Models\Competition'); | |||
| Route::resource('competitions', 'CompetitionsController'); | |||
|
|
|||
| // Competitions | |||
| Route::model('contest', 'Gladiator\Models\Contest'); | |||
There was a problem hiding this comment.
I think this should be plural to follow the other routes
There was a problem hiding this comment.
Also all of our views directories are plural as well (/views/competitions/, /views/waitingrooms/) so maybe update contests to be the same.
There was a problem hiding this comment.
yeah ill change it, as I pointed out to Diego 'ContestsController' just sounded funny to me for some reason #65 (comment)
|
@weerd good for re-review! |
|
stylezci |
| { | ||
| $contest = Contest::create($request->all()); | ||
|
|
||
| return redirect()->action("ContestsController@show", $contest->id)->with('status', 'Contest has been saved!'); |
There was a problem hiding this comment.
use single quotes tho :nitpicky:
There was a problem hiding this comment.
(diego i think you forgot to refresh 😉 )
|
@weerd HTML updated! |
|
|
||
| <div class="form-item -padded"> | ||
| <label class="field-label" for="id">Campaign ID:</label> | ||
| <input type="number" name="campaign_id" id="campaign_id" class="text-field" placeholder="1234" value="{{ $contest->campaign_id or old('campaign_id') }}"/> |
There was a problem hiding this comment.
So this is working correctly now? :)
|
I think StyleCI is complaining cause there's extra tab spacing. Delete that and should be good! |
|
DIEGO I DID IT YOURE A GENIUS |
|
😉 👍 |
What's this PR do?
Adds CRUD STUFF for Contests.
How should this be manually tested?
Pull the branch, can you view/make/edit/delete a contest?
Any background context you want to provide?
*CRUD STUFF is a highly technical term I learned from The Googles.
What are the relevant tickets?
Fixes #59