Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directed.py to use d3json module #42

Merged
merged 6 commits into from
Jan 6, 2015
Merged

Conversation

pbinkley
Copy link
Contributor

@pbinkley pbinkley commented Jan 4, 2015

Here's the first of the threatened PRs (in #41). The directed graph utility now uses a generic module to generate the D3-friendly json, and then optionally output it directly for reuse or embed it in the HTML template directed.html for immediate viewing. The new version is backwards-compatible, in that the default params produce the same output as the old version, but there are now options that can be set on the command line (via optparse).

I hope that this provides a model for generating D3-friendly json in different formats, and I intend to build up d3json.py to do this. Next in line is a timeline bar chart.

@edsu
Copy link
Member

edsu commented Jan 5, 2015

@pbinkley would it be possible to see this pull request with spaces instead of tabs? It should be possible to configure your text editor to do this, but let me know if you run into problems.

@pbinkley
Copy link
Contributor Author

pbinkley commented Jan 5, 2015

Sorry about that - I've just pushed a version with spaces instead of tabs.

edsu added a commit that referenced this pull request Jan 6, 2015
Refactor directed.py to use d3json module
@edsu edsu merged commit 2e31e60 into DocNow:master Jan 6, 2015
@edsu
Copy link
Member

edsu commented Jan 6, 2015

Thanks @pbinkley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants