Refactor directed.py to use d3json module #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pbinkley would it be possible to see this pull request with spaces instead of tabs? It should be possible to configure your text editor to do this, but let me know if you run into problems. |
|
Sorry about that - I've just pushed a version with spaces instead of tabs. |
edsu
added a commit
that referenced
this pull request
Jan 6, 2015
Refactor directed.py to use d3json module
|
Thanks @pbinkley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the first of the threatened PRs (in #41). The directed graph utility now uses a generic module to generate the D3-friendly json, and then optionally output it directly for reuse or embed it in the HTML template directed.html for immediate viewing. The new version is backwards-compatible, in that the default params produce the same output as the old version, but there are now options that can be set on the command line (via optparse).
I hope that this provides a model for generating D3-friendly json in different formats, and I intend to build up d3json.py to do this. Next in line is a timeline bar chart.