-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add citation, update readthedoc config, add 3.12 in CI #71
Conversation
For our needs, the CITATION.cff file seems more relevant that the .zenodo.json file |
@DocOtak I let you add your email address if you wish so |
(The readthedoc error seems to come from an update of sphinx to version 7.3.7, version 7.2 was working) |
The python 3.12 error seems to come from:
|
Looks like xarray also dropped 3.8 support, we should do the same. Some versions policies: SPEC0, NEP 29, Xarray follows NEP 29 for now but I know they discuss switching to SEPC0. If I recall correctly, SPEC0 is faster to drop support for things. I personally usually keep my python one point release behind, so when 3.12 came out, I migrated my personal work from 3.10 to 3.11. |
Seems ready to merge for me. |
@DocOtak could you review? |
Nothing jumped out at me reading the changes with my eyes, which is the classic "looks good to me" type response I suppose. I'll poke at the actual code tomorrow morning (UTC-7). It might be worth experimenting with switching things as much as possible to ruff in a later PR. Absolutely support you being "first author" on anything related to this if the ordering in that citation.cff file matters. P.S. I did see your PhD advisor at Ocean Sciences, he was quite busy with folks interested in his poster so I didn't actually get the opportunity to introduce myself. |
@DocOtak I moved everything to ruff instead of fixing stuff that we would have removed later. Can you review? |
Awesome, I think this is ready to go in. I guess there hasn't been a black run for a while as the style is slightly changing. And I don't know if isort as ever been run on the project. This should close #70 since flake8 will basically be dropped. |
Closes #66