Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add citation, update readthedoc config, add 3.12 in CI #71

Merged
merged 35 commits into from
May 28, 2024

Conversation

rcaneill
Copy link
Collaborator

Closes #66

@rcaneill
Copy link
Collaborator Author

https://support.zenodo.org/help/en-gb/24-github-integration/96-how-does-a-citation-cff-file-affect-metadata-of-my-github-release

For our needs, the CITATION.cff file seems more relevant that the .zenodo.json file

@rcaneill
Copy link
Collaborator Author

@DocOtak I let you add your email address if you wish so

@rcaneill
Copy link
Collaborator Author

(The readthedoc error seems to come from an update of sphinx to version 7.3.7, version 7.2 was working)

@rcaneill
Copy link
Collaborator Author

@rcaneill rcaneill changed the title add citation add citation, update readthedoc config, add 3.12 in CI May 10, 2024
@rcaneill rcaneill added this to the Version 0.4.0 milestone May 10, 2024
@rcaneill
Copy link
Collaborator Author

The python 3.12 error seems to come from:

  1. the fact the numpy version that supports 3.12 dropped 3.8
  2. jupyterlab needs to be updated

@DocOtak
Copy link
Owner

DocOtak commented May 10, 2024

Looks like xarray also dropped 3.8 support, we should do the same.

Some versions policies: SPEC0, NEP 29, Xarray follows NEP 29 for now but I know they discuss switching to SEPC0. If I recall correctly, SPEC0 is faster to drop support for things.

I personally usually keep my python one point release behind, so when 3.12 came out, I migrated my personal work from 3.10 to 3.11.

@rcaneill rcaneill requested a review from DocOtak May 13, 2024 15:58
@rcaneill rcaneill mentioned this pull request May 13, 2024
@rcaneill
Copy link
Collaborator Author

Seems ready to merge for me.
I dropped python 3.8 and added python 3.12.
I added a test to verify that the minimal version available in the pyproject file are passing the tests (and I discovered that we need pint>=0.20)

@rcaneill rcaneill linked an issue May 13, 2024 that may be closed by this pull request
@rcaneill
Copy link
Collaborator Author

@DocOtak could you review?

@DocOtak
Copy link
Owner

DocOtak commented May 25, 2024

Nothing jumped out at me reading the changes with my eyes, which is the classic "looks good to me" type response I suppose. I'll poke at the actual code tomorrow morning (UTC-7). It might be worth experimenting with switching things as much as possible to ruff in a later PR. Absolutely support you being "first author" on anything related to this if the ordering in that citation.cff file matters.


P.S. I did see your PhD advisor at Ocean Sciences, he was quite busy with folks interested in his poster so I didn't actually get the opportunity to introduce myself.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
poetry.lock Show resolved Hide resolved
@rcaneill
Copy link
Collaborator Author

@DocOtak I moved everything to ruff instead of fixing stuff that we would have removed later. Can you review?

@rcaneill rcaneill requested a review from DocOtak May 28, 2024 09:26
@DocOtak
Copy link
Owner

DocOtak commented May 28, 2024

Awesome, I think this is ready to go in. I guess there hasn't been a black run for a while as the style is slightly changing. And I don't know if isort as ever been run on the project.

This should close #70 since flake8 will basically be dropped.

@rcaneill rcaneill merged commit a6df06f into master May 28, 2024
20 checks passed
@rcaneill rcaneill deleted the rcaneill_add_citation2 branch May 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link github repo to zenodo CI testing / black (?) / flake8 / isort (?)
2 participants