Add support for less module #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 08dd005ddf01c757fec4afa3f4d44e8c79ac6e3f)
Signed-off-by: Chuck Fan <fanck0605@qq.com>
For example, sideEffects: true Signed-off-by: Chuck Fan <fanck0605@qq.com>
Signed-off-by: Chuck Fan <fanck0605@qq.com>
Signed-off-by: Chuck Fan <fanck0605@qq.com>
Now, like other style sheets, we don't need to add exclusions in file loader Signed-off-by: Chuck Fan <fanck0605@qq.com>
tux-tn
requested changes
Aug 25, 2021
There was a problem hiding this comment.
Thank you @fanck0605 for working on this issue. I will try to test your PR with different options, can you please address my comment concerning clone
|
Thank you @fanck0605! I really appreciate the update to the documentation in README, and also the great test cases. Also thanks @tux-tn for the review! I will leave a comment on that review as well |
Signed-off-by: Chuck Fan <fanck0605@qq.com>
Signed-off-by: Chuck Fan <fanck0605@qq.com>
Signed-off-by: Chuck Fan <fanck0605@qq.com>
Signed-off-by: Chuck Fan <fanck0605@qq.com>
tux-tn
approved these changes
Aug 26, 2021
|
Thanks @fanck0605! This is now merged and released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we can use less and less module at the same time without any additional configuration!
This change takes into account forward compatibility, but it still does not guarantee that all old configurations will work properly in the new version.
We can use the
optionsobject to configure less and less modules at the same time.If we just want to modify some less variables, this will be enough.
If we need to modify less and less module separately, please use
modifyLessRuleandmodifyLessModuleRule.This works fine in my project, but still needs more testing to make sure there are no potential problems!